#371 Provide separate type definitions for CommonJS and ES modules

MikeMcl · MikeMcl · commit a543ab5444c7 · 2025-04-03T18:30:19.000+01:00
diff --git a/bignumber.d.cts b/bignumber.d.cts
@@ -0,0 +1,2 @@
+/// <reference path="./bignumber.d.ts" />
+export = BigNumber;
diff --git a/bignumber.d.mts b/bignumber.d.mts
@@ -0,0 +1,2 @@
+/// <reference path="./bignumber.d.ts" />
+export default BigNumber;
diff --git a/bignumber.d.ts b/bignumber.d.ts
@@ -5,9 +5,7 @@
 
 // Documentation: http://mikemcl.github.io/bignumber.js/
 //
-// Exports:
-//
-//   class     BigNumber (default export)
+//   class     BigNumber
 //   type      BigNumber.Constructor
 //   type      BigNumber.ModuloMode
 //   type      BigNumber.RoundingMode
@@ -31,9 +29,7 @@
 //
 // The use of compiler option `--strictNullChecks` is recommended.
 
-export default BigNumber;
-
-export namespace BigNumber {
+declare namespace BigNumber {
 
   /** See `BigNumber.config` (alias `BigNumber.set`) and `BigNumber.clone`. */
   interface Config {
@@ -327,7 +323,7 @@ export namespace BigNumber {
   type Value = string | number | Instance;
 }
 
-export declare class BigNumber implements BigNumber.Instance {
+declare class BigNumber implements BigNumber.Instance {
 
   /** Used internally to identify a BigNumber instance. */
   private readonly _isBigNumber: true;
@@ -1828,4 +1824,4 @@ export declare class BigNumber implements BigNumber.Instance {
   static set(object?: BigNumber.Config): BigNumber.Config;
 }
 
-export function BigNumber(n: BigNumber.Value, base?: number): BigNumber;
+declare function BigNumber(n: BigNumber.Value, base?: number): BigNumber;
diff --git a/bignumber.js b/bignumber.js
@@ -906,7 +906,7 @@
 
         // xc now represents str converted to baseOut.
 
-        // THe index of the rounding digit.
+        // The index of the rounding digit.
         d = e + dp + 1;
 
         // The rounding digit: the digit to the right of the digit that may be rounded up.
diff --git a/bignumber.mjs b/bignumber.mjs
@@ -903,7 +903,7 @@ function clone(configObject) {
 
       // xc now represents str converted to baseOut.
 
-      // THe index of the rounding digit.
+      // The index of the rounding digit.
       d = e + dp + 1;
 
       // The rounding digit: the digit to the right of the digit that may be rounded up.
diff --git a/package.json b/package.json
@@ -23,13 +23,21 @@
   "main": "bignumber",
   "module": "bignumber.mjs",
   "browser": "bignumber.js",
-  "types": "bignumber.d.ts",
+  "types": "bignumber.d.cts",
   "exports": {
     ".": {
-      "types": "./bignumber.d.ts",
-      "require": "./bignumber.js",
-      "import": "./bignumber.mjs",
-      "browser": "./bignumber.js"
+      "import": {
+        "types": "./bignumber.d.mts",
+        "default": "./bignumber.mjs"
+      },
+      "require": {
+        "types": "./bignumber.d.cts",
+        "default": "./bignumber.js"
+      },
+      "browser": {
+        "types": "./bignumber.d.cts",
+        "default": "./bignumber.js"
+      }
     },
     "./bignumber.mjs": "./bignumber.mjs",
     "./bignumber.js": "./bignumber.js",

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+/// <reference path="./bignumber.d.ts" />`
	`2`	`+export = BigNumber;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+/// <reference path="./bignumber.d.ts" />`
	`2`	`+export default BigNumber;`