Skip to content

fix: update toFraction return type #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
acdibble wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update toFraction return type #387

acdibble wants to merge 2 commits into from

Conversation

@acdibble
Copy link

@acdibble acdibble commented Jun 4, 2025

If the BigNumber instance is NaN, toFraction returns a BigNumber instance instead of a BigNumber tuple.

rajeshthummalapally and others added 2 commits May 9, 2025 19:06
@rajeshthummalapally
MikeMcl#385 Fix link to licence from README
eb6a1f2
@acdibble
fix: update types
b306261 
If the `BigNumber` instance is `NaN`, `toFraction` returns a `BigNumber` instance instead of a `BigNumber` tuple.
@acdibble acdibble changed the title fix: update types fix: update type Jun 4, 2025
@acdibble acdibble changed the title fix: update type fix: update toFraction return type Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acdibble @rajeshthummalapally