Skip to content

feat: add rm support to stringify #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MikeMcl merged 4 commits into from
Sep 7, 2020
Merged

feat: add rm support to stringify #144

MikeMcl merged 4 commits into from
Sep 7, 2020

Conversation

@nutboltu
Copy link
Contributor

@nutboltu nutboltu commented Aug 24, 2020 •
edited
Loading

This PR fixes #117

  • Adding rm as a second optional parameter for toExponential

  • Adding rm as a second optional parameter for toFixed

  • Adding rm as a second optional parameter for toPrecision

  • Adding uglify-js as devDependencies for build

  • Docs are updated as per changes.

  • Unit tests

@nutboltu nutboltu marked this pull request as ready for review August 26, 2020 13:15
@nutboltu
Copy link
Contributor Author

nutboltu commented Aug 26, 2020

@MikeMcl would you please take a look? I will add unit tests after getting an initial review from you.

MikeMcl
MikeMcl requested changes Aug 27, 2020
View reviewed changes
Copy link
Owner

@MikeMcl MikeMcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to reply this very evening anyway. Honest!

I've actually already done this work - the code part anyway - but, as usual, one change leads to another, and I have a bit more refactoring to do before pushing.

I'll take this PR from you anyway, though, as it includes other stuff. When I publish, I will probably remove the minified version and all that goes with it.

Thanks for your good work.

@nutboltu
Copy link
Contributor Author

nutboltu commented Aug 28, 2020 •
edited
Loading

@MikeMcl no worries. Thanks for your time to review. Feel free to take my code to your work.
However, if you want my PR to get merge first and then you'll start working on top of it, that would be another option. Let me know which works for you.

@MikeMcl MikeMcl merged commit b14a15f into MikeMcl:master Sep 7, 2020
@nutboltu nutboltu changed the title feat: add rm support to strigify and uglify-js as package dependencies feat: add rm support to stringify Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcl MikeMcl MikeMcl requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

toFixed include RM as parameter

2 participants

@nutboltu @MikeMcl