Fixing a typo in README.md #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For "Set up" section in documentation, there was a typo in import example for ES6. "import Big from 'big.jms'" instead of "import Big from 'big.js'"
Owner
|
The existing file extension is correct: big.mjs is the ES6 module version of big.js. See, for example, the Node.js documentation:
However, you are correct that there is a mistake - for the import to work in Node.js and browsers, it should be a relative path import Big from './big.mjs';If you update this PR accordingly, I will accept it. |
Contributor
Author
|
Sorry for the confusion with the file extension. I didn't even know before that there are such experimental modules. I restored the ".mjs" and changed the path to relative as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For "Set up" section in documentation, there was a typo in import example for ES6.
"import Big from 'big.jms'"
instead of
"import Big from 'big.js'"